Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Nightly][Master] Making master nightly green again #15856

Merged
merged 3 commits into from
Jul 29, 2024
Merged

[CI][Nightly][Master] Making master nightly green again #15856

merged 3 commits into from
Jul 29, 2024

Conversation

dkijania
Copy link
Member

@dkijania dkijania commented Jul 23, 2024 •
edited
Loading

Introduced two changes which should make develop nightly green again:

  • soft fail to hf test (while fixing is in progress)
  • removing delegation backend unit test
  • fixing terraform test

dkijania and others added 2 commits July 23, 2024 17:31
@dkijania
nightly on develop cleanup. Marking HF test as optional and removing …
6c51bac 
…delegation backend unit test
@dkijania
Merge pull request #15858 from MinaProtocol/terraform-tests
146ce26 
Fix Terraform tests by synthetically creating required seed peerid files
@dkijania dkijania changed the title Merge pull request #15794 from MinaProtocol/ci/build_mainnet_and_devn… [CI][Nightly][Master] Making master nightly green again Jul 23, 2024
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania dkijania marked this pull request as ready for review July 24, 2024 11:48
@dkijania dkijania requested a review from a team as a code owner July 24, 2024 11:48
@SanabriaRusso
Copy link
Collaborator

Master nightly: https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/2293

@dkijania
Copy link
Member Author

!help-merge-me

This was referenced Jul 29, 2024
Merged
Merged
@mrmr1993
Copy link
Member

!approved-for-mainnet

@mrmr1993 mrmr1993 merged commit eaca3aa into master Jul 29, 2024
24 of 25 checks passed
@mrmr1993 mrmr1993 deleted the dkijania/clean_nightly_on_master branch July 29, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanabriaRusso SanabriaRusso SanabriaRusso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkijania @SanabriaRusso @mrmr1993