Make muton self-contained #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
State in README.md that muton requires lodash as dependency.
Why: * Webpack makes it easier to export the library in several module formats. This change addresses the need by: * Use muton as a global variable
Why: * Different projects use different versions of lodash, which means that some incompatibility will happen (it already did) This change addresses the need by: * Make lodash self contained without external dependencies.
|
Looks good to me ;) |
|
This makes sense |
|
@antoniocapelo This way, all muton dependencies are included in the final bundle, which means that muton itself is independent of the lodash's version being used in the parent project. This also means that some functions will be duplicated between project's lodash, and muton's lodash, but those should have minimal impact. (I hope) |
|
Lgtm 👍 Thank you for this @Couto ;) |
* Bump minor version * Update documentation * Update travis config to also test in newer versions of nodejs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two major differences:
Webpack makes it easier to bundle into different module standards (amd, commonjs, umd...), without depending on third-party libs like
amdefine.Different projects use different versions of lodash (some are already using v4, others are still using v3.x) this means that lodash can no longer depend on the lodash present in the enviroment, since it breaks with some methods in v.4, so it now bundles the functions that it requires from lodash, individually.