Reduce overhead from using RaygunBreadcrumb by lazy allocation of CustomData #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -439,7 +439,7 @@ public void SendInBackground(Func<RaygunMessage> raygunMessage) | |||
| private void StripAndSend(Exception exception, IList<string> tags, IDictionary userCustomData, RaygunIdentifierMessage userInfo, DateTime? currentTime) | |||
| { | |||
| var requestMessage = BuildRequestMessage(); | |||
| var breadcrumbs = _breadcrumbs.ToList(); | |||
| IList<RaygunBreadcrumb> breadcrumbs = BuildBreadCrumbList(); | |||
There was a problem hiding this comment.
Curious to know why this is better than calling .ToList() ?
There was a problem hiding this comment.
_breadcrumbs.ToList() will allocate an enumerator and a List-object. The BuildBreadCrumbList() will also allocate an enumerator, but only allocate a List-object when breadcrumbs are found.
| Level = RaygunBreadcrumbLevel.Info; | ||
| Type = RaygunBreadcrumbType.Manual.ToString(); | ||
| Type = nameof(RaygunBreadcrumbType.Manual); |
There was a problem hiding this comment.
Love this, I always forget to do it.
phillip-haydon
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also skip StackTrace probing, when BreadCrumb is prefilled.