Add fully quality module name and remove the android handled #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenolightning
commented
May 27, 2024
| @@ -49,7 +49,6 @@ private static void AndroidUnhandledExceptionHandler(object sender, object excep | |||
| { | |||
| var exceptionArgsType = exceptionArgs.GetType(); | |||
| exception = (Exception)exceptionArgsType.GetProperty("Exception").GetValue(exceptionArgs); | |||
| exceptionArgsType.GetProperty("Handled")?.SetValue(exceptionArgs, true); | |||
There was a problem hiding this comment.
We don't actually need this, this just prevents the app from crashing on android.
If this is desired behaviour the user can hook this and do it in their code, but we shouldn't be affecting functionality
|
Released as 11.0.0-pre2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the module name, to fully qualify the path to load.
That way if the executing directory is different to the module directory, it can load the file correctly.
Also remove the unhandled = true flag from Android