LiteLoader plugin unusable with subprojects

[mattmess1221]

I have a couple projects with the liteloader plugin applied. When the root project has it, it crashes. I'm suspecting a configuration is somehow null.

Log: http://pastebin.com/QthGEk4t
Repo: https://github.com/killjoy1221/TabbyChat-2/tree/1.8.9

[AbrarSyed]

@Mumfrey !!!

[Mumfrey]

Fix should be something like this

[Mumfrey]

I'm on an event from tomorrow for the following week so if that doesn't fix it then I'll look into it when I get back.

[mattmess1221]

On this note, what's the reason you decided to add liteloader to every project instead of just the one it was applied on? I think that removing the allprojects entirely would resolve it.

[Mumfrey]

@killjoy1221 oh I see you're right. I was in a hurry yesterday so didn't actually look at it that closely. I think what happened is that the allprojects closure is supposed to add the repo the same way it's done here, here and here but the second part of the logic should not be in the allprojects closure.

This makes the fix look more like this where the logic for that method is moved out of the allprojects closure.

[Mumfrey]

Hey @killjoy1221 I'm back now, if you can confirm that the changes in the commit I mentioned above fix the issue then I'll open a PR.

[mattmess1221]

👍

[AbrarSyed]

PR please?