Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dane-java7] Do not perform unauthenticated reverse IP lookup #107

Merged
merged 3 commits into from
Jul 30, 2020

Conversation

Flowdalic
Copy link
Collaborator

Thanks to Viktor Dukhovni for reporting this.

@coveralls
Copy link

coveralls commented Jul 28, 2020

Pull Request Test Coverage Report for Build 198

  • 0 of 35 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 52.541%

Changes Missing Coverage Covered Lines Changed/Added Lines %
minidns-dane-java7/src/main/java/org/minidns/dane/java7/DaneExtendedTrustManager.java 0 35 0.0%
Files with Coverage Reduction New Missed Lines %
minidns-dane-java7/src/main/java/org/minidns/dane/java7/DaneExtendedTrustManager.java 1 0%
Totals Coverage Status
Change from base Build 193: -0.2%
Covered Lines: 2915
Relevant Lines: 5548

💛 - Coveralls

@Flowdalic Flowdalic force-pushed the unauthenticated-reverse-lookup branch 2 times, most recently from f633497 to 77278a2 Compare July 28, 2020 11:51
@Flowdalic Flowdalic changed the base branch from master to 1.0 July 28, 2020 20:13
@Flowdalic Flowdalic changed the title DRAFT [dane-java7] Do not perform unauthenticated reverse IP lookup [dane-java7] Do not perform unauthenticated reverse IP lookup Jul 28, 2020
Thanks to Viktor Dukhovni for reporting this.
Instead of checkClientTrusted(), this should call
checkServerTrusted().
@Flowdalic Flowdalic force-pushed the unauthenticated-reverse-lookup branch from 77278a2 to a0e0ee8 Compare July 28, 2020 20:14
@Flowdalic Flowdalic merged commit 290d2b9 into MiniDNS:1.0 Jul 30, 2020
@Flowdalic Flowdalic deleted the unauthenticated-reverse-lookup branch December 25, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants