New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using with MiniProfiler with MVC3 and EF6 #81

Closed
jdonaldson10 opened this Issue Jul 28, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@jdonaldson10

jdonaldson10 commented Jul 28, 2014

Currently I have an MVC3 application that uses EF6 for it's data access. I am able to get things up and running just fine using the MiniProfiler.MVC3 package and have the timings all appear.

However, after adding MiniProfiler.EF6 package it seems that I am no longer able to resolve the @MiniProfiler.RenderIncludes() method in the StackExchange.Profiling namespace.

I do realise the mvc3 version hasn't seen much (any?) updates in a long while, really I am just after confirmation if this is at all possible before spending more time on it.

Plus I can make do without the db profiling until I have time in my schedule to bring the application up to mvc 4/5

@yellis

This comment has been minimized.

Member

yellis commented Jul 31, 2014

As you noted, the MVC3 nuget hasnt been updated in quite a while. It is still on v2 and was built against the v2 main MiniProfiler dll. EF6 on the other hand has only ever been built against the v3 main dll (and since it requires v3, it most likely upgraded your main MiniProfiler dll from v2 to v3 when you installed the EF6 package). So I am not surprised that something is off when trying to combine these. Unfortunately I can't really justify spending time right now trying to make these compatible anymore. If you would like to submit a pull request to bring the MVC3 project up to date I would be happy to look it over.

@jdonaldson10

This comment has been minimized.

jdonaldson10 commented Jul 31, 2014

Sounds about right to me...always worth asking though 😄

I don't have much free time to work on this one at the moment. Even with that I would probably be better placed putting that time into upgrading my app to mvc4 (as I am planning to do that anyway!). Though if some does free up I may just look into it. Feel free to close this off if you wish as it answered my question fine.

It might be helpful to add this to the documentation or readme.md perhaps? Or even just leave this issue open for anyone experiencing the same problem?

@yellis

This comment has been minimized.

Member

yellis commented Aug 5, 2014

Updated readme

@yellis yellis closed this Aug 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment