Mini profiler not running on start #27
Conversation
…tatic It seems that MiniProfiler stopped running on start after the pull request that adds MiniProfiler to the middleware based on where other Middleware was in the stack. It seems MiniProfiler needs to be added during initialization not after or else it won't run. From the research I did I think it would be better to add MiniProfiler before ActionDispatch::Static instead of checking against the current stack. That way if Rack::Deflater is alse added before ActionDispatch::Static then Rack::Delflater will still be before MiniProfiler.
With the new insert_before ActionDispatch::Static these attributes/instance vars are no longer necessary
|
ActionDispatch::Static is a problem though, it may not exist. |
|
Apologies I am not familiar with middleware stacks, this is relatively new territory for me. I think I found a better solution though. Do you have an issue (or experienced an issue?) with using It will add it to the bottom of the stack instead of the top which will eliminate the problems those using Rack::Deflater or HerokuDeflater::SkipBinary which will get inserted at the top. |
… exist ActionDispatch::Static may not exist so I've replaced insert_before with use. This will drop MiniProfiler to the bottom of the stack instead of the top and alleviate the problems with Rack::Deflater, HerokuDeflater::SkipBinary and MiniProfiler not running in the after_initialize block.
|
The trouble with that is that we want to register mini profiler first so it is able to measure how the rest of the middlewares in the stack perform. If we register it last mini profiler will return inaccurate data. |
|
Hrm ok, that makes sense. Master as it is right now doesn't run at all and I'm not sure why. Looking at In the after_initialize method the Any ideas? |
|
Sorry for the delay, I should have this fixed today |
|
Hey, no worries, I was trying to help. Seems there are a lot of similar issues on github dealing with the stack order of middleware. Definitely not a trivial issue to fix. :) |
|
no worries, I ended up reverting the regression so all should be working On Fri, Nov 22, 2013 at 1:18 PM, Eileen notifications@github.com wrote:
|
Since updating the railtie to install after known dependencies (HerokuDeflater::SkipBinary and Rack::Deflater) I could not get MiniProfiler to render on start up (from the master branch). The javascript and views were not being inserted into my app.
It seems that because the insert is being run after_initialization that MiniProfiler isn't getting added. I added Rack::Deflator to see if it ran correctly with the new insert_position and the views still were not rendered.
I think the best method would be to instead insert_before ActionDispatch::Static - this is how both HerokuDeflater::SkipBinary and Rack::Deflater are inserted into the middleware as well. This results in the correct order without having to rely on an array of possible middleware.