Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rpcs and syncvars now support generic components #574
feat: rpcs and syncvars now support generic components #574
Changes from 12 commits
2039d3c
176ca02
8c466df
ec26f4d
d138270
681cb62
5dffe7d
fec445d
3065e0a
2750526
96d63f2
b5e4de4
cfc9a6f
86a8205
cb40e99
577bf5c
96bcaae
b5dee85
9991d12
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a rule of thumb, don't explain what this is doing. Explain why instead.
I can see that you are duplicating the method ref just by reading the code, the comment is redundant. What I can't figure out is why we are doing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed duplicate and changed it with some more straightforward code. I hope it becomes more clear.
Removed the duplicate in 86a8205 and added a comment in cb40e99.