…otten proximity checker redone only. Has bug atm need fix later. Used james code from distance checker.

…i. Proximity checker currently only one that is finished and tested atm.

…null references issues due to adding aoi systems at runtime.

implemented scene visibility
fixed docs ref.
added new unregister so if gameobjects get destroyed they unregister from visibility system.

Implemented a new multi visibility system performance benchmark. Runs Scene + proximity systems.

… objects global but not others everything will still work. New global system is internal cannot be used outside

Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>

Still trying to improve benchmark speeds.

- adding explicit (so it can be run manually)
- create new scene for each client, with no physics
- adding netid to obj names
- adding setup/clean prefabs (so they are changed before they are used by enemy spawner, world.Spawned might be too late to add)

registering in onenable is sometimes too early.
It will also cause unspawned objects to be included in AOI, and maybe sent to clients

Also adding todo

- NetworkVisibility to VisibilitySystem
- NetworkProximityCheckerVisibility to DistanceVisibilitySystem
- SceneVisibilityChecker to SceneVisibilitySystem

- _visibilitySystemData to _data
- VisibilitySystemData Observers

moving Comparer so it is not hidden inside IM. Makes it more obvious what is going on when using the sturct in a hashset

we can just use the system itself since it'll have the reference to the dictionary

- BaseVisibilityInspector to VisibilitySystemFactory
- NetworkSceneChecker to SceneVisibilityFactory
- NetworkProximityChecker to DistanceVisibilityFactory

we dont need this layer of abstraction

- removing base settings
- making register take identity and settings
- making unregister just take identity

RegisterObject makes more sense if it is given the object, rather than settings that has the object.

This will also reduce extra code if a system does not need any settings (if could just pass in null)

- renamed OnAuthenticated  to RebuildForPlayer

OnAuthenticated seems like a bad name because we will need to call it more than just OnAuthenticated, Like when we spawna  new character for the player

making sure we still call IM functions are same time as before
- need to rebuild observers for player after setting character
- moving show to player to IM
- adding OnSpawn and OnDestroy instead of using world events (we need to control the order, our event might be called before/after user added events)

can just use scene instead

changing how it is created.
pass variables around rather than using fields

- InterestManager lazy intialize
- VisibilitySystemFactory adds to IM on awake, and removes in destroy

Key points:
- IM always exists on SOM
- Systems can and should be added before Server Starts
- Systems will add them selves to IM when they are constructed

…ects