Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Makefiles #257

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
.idea
cri-dockerd
build
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion packaging/Makefile → build/packaging/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include common.mk
include ../common.mk

APP_DIR:=$(realpath $(CURDIR)/..)

Expand Down
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion packaging/deb/Makefile → build/packaging/deb/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include ../common.mk
include ../../common.mk

APP_DIR:=$(realpath $(CURDIR)/../../)
GITCOMMIT?=$(shell cd $(APP_DIR) && git rev-parse --short HEAD)
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion packaging/rpm/Makefile → build/packaging/rpm/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include ../common.mk
include ../../common.mk

APP_DIR:=$(realpath $(CURDIR)/../../)
STATIC_VERSION:=$(shell ../static/gen-static-ver $(APP_DIR) $(VERSION))
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include ../common.mk
include ../../common.mk

APP_DIR:=$(realpath $(CURDIR)/../../)
CGO_ENABLED ?= 0
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include ../common.mk
include ../../common.mk

APP_DIR:=$(realpath $(CURDIR)/../../)
GO_BASE_IMAGE=golang
Expand Down
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion docs/content/development/creating-a-release.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ weight: 3
These are the steps in order to create a new release for `cri-dockerd`. These steps will need to be done by a project maintainer.

1. Setup the repo for a new release
1. Change the version found in `VERSION`, `cmd/version/version.go`, and `packaging/common.mk` to the new version
1. Change the version found in `VERSION`, `cmd/version/version.go`, and `build/common.mk` to the new version
2. Create a PR with these changes and merge them to master
3. Build the release artifacts using `make release`
4. Verify the artifacts in the `build/release` directory and make sure they look correct
Expand Down