Improve azure provisioner: install specific packages, update field names and fix cluster resize #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naumvd95
approved these changes
Jun 28, 2018
naumvd95
suggested changes
Jun 29, 2018
|
@katyafervent AFAIK fix already merged |
|
Vlad, thanks for the information, but how that fix should affect my change? I believe wouldn't depend on azure fixes anymore :) |
|
its just for notice @katyafervent ) |
svnovikov
previously approved these changes
Jul 3, 2018
|
@svnovikov does eks CRUD cluster works fine? |
katyafervent
changed the title
added 4 commits
July 4, 2018 09:06
Often azure brokes packege dependencies and our CI became broken. Install only that azure packages, tht we are using.
Rename "Client" to "Application" and "Tenant" to "Directory" since they are used in the azure docs that we are referring to.
Otherwise cluster may not be resized
Since we are performing save operation, witch modifies an object state and not just reading it.
naumvd95
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often azure brakes package dependencies and our CI became broken.
Install only that azure packages, that we are using.