Make k8s images configurable #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katyafervent
force-pushed
the
make-k8s-images-confogurable
branch
from
ebaa795
to
bef4094
Compare
naumvd95
reviewed
Jul 12, 2018
| self.meta["master_count"] = self.cluster.metadata["master_count"] | ||
| mc = self.cluster.metadata["master_count"] | ||
| if mc % 2 == 0: | ||
| raise ValueError("Master node count must be an odd number at least 3 or greater") |
There was a problem hiding this comment.
redundant with what?
|
do we need to forward it in compose-configs? |
|
this config is used in compose-demo file. I suggest to keep all Mirantis-related params in a one config |
katyafervent
force-pushed
the
make-k8s-images-confogurable
branch
2 times, most recently
from
d0ad51f
to
4c46bb3
Compare
naumvd95
reviewed
Jul 12, 2018
| with open(os.path.join(dst, "all.yml"), "a") as all_yaml: | ||
| all_yaml.write("\ncloud_provider: openstack\n") | ||
| data_to_add = {'cloud_provider': 'openstack'} |
There was a problem hiding this comment.
imo unclear naming , maybe kubespray_configuration?
There was a problem hiding this comment.
kubespray_configuration is located at "all.yml" and we are open this file for append and in data_to_add dictionary contains everything that will be appended
|
OK, LGFM, we can merge it , if it tested properly |
naumvd95
previously approved these changes
Jul 12, 2018
ekhomyakova
reviewed
Jul 13, 2018
kqueen/config/demo.py
Outdated
| @@ -33,3 +33,16 @@ class Config(BaseConfig): | |||
| # Creds for Kqueen Read-only user | |||
| LDAP_DN = 'cn=admin,dc=example,dc=org' | |||
| LDAP_PASSWORD = 'heslo123' | |||
|
|
|||
| # Images for Kubespray (available images that can be provided is listed in the link below) | |||
katyafervent
force-pushed
the
make-k8s-images-confogurable
branch
from
4c46bb3
to
a598950
Compare
katyafervent
force-pushed
the
make-k8s-images-confogurable
branch
from
b801376
to
b2ad51f
Compare
ekhomyakova
approved these changes
Jul 13, 2018
naumvd95
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.