-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Track costs for streaming with OpenAI #282
Conversation
Changes look good! can you update https://docs.mirascope.io/latest/concepts/tracking_costs_for_llm_providers/#cost-tracking-for-streaming to reflect your new updates? |
Sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you for contributing 🙏
@tvj15 can you please merge in current dev? I made a change to the GitHub action for codecov that will hopefully resolve the rate limit failures. |
Yes it is turned on. I am not sure of the issue. Shall I raise a new PR into dev? |
Hmm, probably an issue on my end then. For now, can you just merge dev into this PR so I can re-run the workflows? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #282 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 138 138
Lines 6802 6927 +125
==========================================
+ Hits 6802 6927 +125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Made changes as discussed on #214.
Now, the user when iterating through the stream can check if cost exists like this: