Added Schma edit #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamzaks
requested changes
Oct 6, 2021
| @@ -45,7 +45,7 @@ export class FormComponent implements OnInit { | |||
| sections: [], | |||
| } | |||
|
|
|||
| onSnapshot(doc(firestore, "admin/schema"), (snapshot) => { | |||
| onSnapshot(doc(firestore, "admin/schema1"), (snapshot) => { | |||
| } from "app/services/the-blue-alliance.service" | ||
| import { FormControl } from "@angular/forms" | ||
|
|
||
| interface section { |
There was a problem hiding this comment.
Interfaces should start with a capital letter.
Also, isn't Widget defined somewhere else? and schema? and section?..
Comment on lines
161
to
164
| let stringSchema = JSON.parse(JSON.stringify(this.schema)) | ||
| await setDoc( | ||
| doc(this.firestore, "admin/schema1"), | ||
| Object.assign({}, stringSchema) |
There was a problem hiding this comment.
What is all of this JSON parse stringily Object assign misery? Just set the doc to this.schema
noamzaks
approved these changes
Oct 6, 2021
noamzaks
approved these changes
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.