Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.8 runtime support #1971

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Conversation

Amwam
Copy link
Contributor

@Amwam Amwam commented Dec 12, 2019

Description

Adds python38 as a runtime.

Mimicked #1762 as a guide for the changes.
The incompatable change was the use of escape and parse_qs from cgi.

I also had to limit the docutils package so it matches botocode. A new version released on December 4th 2019 (https://pypi.org/project/docutils/0.16b0.dev0/#description) was being installed, which then caused conflicts when trying to install botocore. Fixed in master

GitHub Issues

Resolves #1968

@coveralls
Copy link

coveralls commented Dec 12, 2019

Coverage Status

Coverage increased (+0.2%) to 33.6% when pulling 261d0a4 on Amwam:feature/python38 into 746385d on Miserlou:master.

@Amwam
Copy link
Contributor Author

Amwam commented Dec 13, 2019

Not sure why the coverage is reporting as being lower.

@Amwam
Copy link
Contributor Author

Amwam commented Dec 16, 2019

It seems coveralls has a limit on the coverage version, as 5.0 as only recently been released. Pinning the version has fixed the coverage tests.

@Aulig
Copy link

Aulig commented Dec 23, 2019

Would be great if this got merged :)

@kimbriancanavan
Copy link
Contributor

Zappa/zappa/core.py

Lines 285 to 290 in 261d0a4

if self.runtime == 'python2.7':
self.manylinux_wheel_file_suffix = 'cp27mu-manylinux1_x86_64.whl'
elif self.runtime == 'python3.6':
self.manylinux_wheel_file_suffix = 'cp36m-manylinux1_x86_64.whl'
else:
self.manylinux_wheel_file_suffix = 'cp37m-manylinux1_x86_64.whl'

Will need to add 'python3.8' runtime here to set the wheel suffix correctly 👍

@Amwam
Copy link
Contributor Author

Amwam commented Jan 6, 2020

@kimbriancanavan Good spot, fixed. Thanks!

@mcrowson mcrowson merged commit ea3fe6a into Miserlou:master Feb 5, 2020
@khafatech
Copy link

Thanks for merging @mcrowson ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.8
6 participants