Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: お知らせの確認待機時間・優先順位機能 #151

Merged
merged 6 commits into from
Aug 19, 2023
Merged

feat: お知らせの確認待機時間・優先順位機能 #151

merged 6 commits into from
Aug 19, 2023

Conversation

u1-liquid
Copy link
Member

@u1-liquid u1-liquid commented Aug 17, 2023 •
edited
Loading

What

feat: refine announcement (misskey-dev#11497) のマージ及び #107 #118 #131 のリワーク
ついでに misskey-dev#11497 の問題点を幾つか修正した
（announcementCreatedが正しく処理されない・ユーザー情報画面でお知らせを作成できないなど）

Why

主要機能の差分を減らす

Additional info (optional)

  • ダイアログ型お知らせがページ再読み込みとかしなくてもすぐ出るようになった
  • ローカルテスト中にバナー型・ダイアログ型の場合たまに1発目のページ再読み込みで出てこない場合があったが、解決策は見つからなかった

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@u1-liquid
feat: お知らせの確認待機時間・優先順位機能
6893e5d 
b7fd6bf33a835fd73c2a86eb007074d3680f6efd によるリワーク

This reverts commit eeef396
This reverts commit 04fefb2
This reverts commit 5762512
riku6460
riku6460 reviewed Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@riku6460 riku6460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

概ね良さそう

packages/backend/migration/1691649257651-refine-announcement.js Show resolved Hide resolved
@u1-liquid u1-liquid merged commit f2bd8ca into MisskeyIO:io Aug 19, 2023
14 checks passed
@u1-liquid u1-liquid deleted the feat-announcements-rework branch August 19, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberRex0 CyberRex0 CyberRex0 approved these changes

@riku6460 riku6460 riku6460 approved these changes

Assignees
No one assigned
Labels
packages/backend:test packages/backend packages/frontend packages/misskey-js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@u1-liquid @riku6460 @CyberRex0