Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

简单添加了将牛牛的名片设置成随机群友的(每一小时) #50

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

MeteoricShower
Copy link
Contributor

No description provided.

@MistEO
Copy link
Owner

MistEO commented Feb 5, 2023

或许可以考虑作为一个单独的模块?新建个文件夹,而不是放在复读里面

@MeteoricShower MeteoricShower changed the title 简单添加了将牛牛的名片设置成随机群友的(每两小时) 简单添加了将牛牛的名片设置成随机群友的(每一小时) Feb 5, 2023
@MeteoricShower
Copy link
Contributor Author

获取群友qq号的功能用到了Chat类里的private成员,所以保留了一个函数在类里面,其他的单独开了个插件,看看这样行不行

Copy link
Owner

@MistEO MistEO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可能还可以考虑下性能问题(我这里挂了几千个群,不知道同时改会不会出问题,或者说会不会被封号 orz)。比如 get_change_name_id 的时候不是 100% append,或者每次最多只改 XX 个群超过直接 break

src/plugins/rename/__init__.py Outdated Show resolved Hide resolved
@MistEO MistEO mentioned this pull request Feb 6, 2023
@MistEO
Copy link
Owner

MistEO commented Feb 6, 2023

Thanks for your contributions!

@MistEO MistEO merged commit 89ac12f into MistEO:master Feb 6, 2023
group_replies = Chat._reply_dict[group_id]
if not len(group_replies):
return
bot_id = random.choice(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

发现一个小问题,如果有很多个 bot 账号,抽到的 bot_id 并不一定在每个群里

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哦哦原来是有好多bot账号的,怪不得bot_id那里没看太懂(),我再去改改

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我改好啦=。=

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

辛苦大佬!qwq

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

尴尬,发现写错两个地方,重新推送了_(:з」∠)_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants