Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: look for schemes and templates in config dir #48

Merged
merged 3 commits into from
May 22, 2022

Conversation

loiccoyle
Copy link
Contributor

@loiccoyle loiccoyle commented Mar 3, 2022

Hi !

I was having trouble with my custom templates getting overwritten when using flavours update all so I made some changes so that custom templates can live somewhere else and don't get destroyed when updating.

In short, flavours will also look for schemes & templates in the user's config dir, e.g.:

  • scheme: ~/.config/flavours/schemes/myscheme/myscheme.yaml
  • template: ~/.config/flavours/templates/mysoftware/templates/mytemplate.mustache

Added bonus, the custom schemes/templates can more easily be packaged/managed with my other dot files !

I haven't tested it very thoroughly but do with this what you will :)

@Misterio77
Copy link
Owner

Thank you! This is an awesome solution for the problem.

Would mind updating the docs too, if possible?

@loiccoyle
Copy link
Contributor Author

Sorry, I didn't see your reply 🤦🏻‍♂️, I'll update the docs when I get the chance.

flavours will also look for schemes & templates in the user's config dir, e.g.:

* scheme: `~/.config/flavours/schemes/myscheme/myscheme.yaml`

* template: `~/.config/flavours/templates/mysoftware/templates/mytemplate.mustache`
@loiccoyle
Copy link
Contributor Author

I added a section to the readme, let me know what you think.

@loiccoyle
Copy link
Contributor Author

@Misterio77 friendly ping 😛

@Misterio77
Copy link
Owner

Misterio77 commented May 22, 2022

Oops sorry for the late reply, missed the notification entirely.

Documentation looks good! Overall everything LGTM, are we ready to merge?

@Misterio77
Copy link
Owner

Misterio77 commented May 22, 2022

(Just a quick fix to integrate these changes with #52's)

@Misterio77 Misterio77 mentioned this pull request May 22, 2022
@loiccoyle
Copy link
Contributor Author

Oops sorry for the late reply, missed the notification entirely.

No worries

Documentation looks good! Overall everything LGTM, are we ready to merge?

All good for me !

@Misterio77 Misterio77 merged commit 606817e into Misterio77:master May 22, 2022
@Misterio77
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants