Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical screen fix #67

Merged
merged 8 commits into from
Nov 7, 2020
Merged

Conversation

p4mela-g
Copy link
Contributor

@p4mela-g p4mela-g commented Nov 3, 2020

This PR fixes #23

Tested with python version - 3.6.9

On operating system - Linux

Add code to vertical screen reduction check, leading to the desired behavior which is to display the message and close the application
- Fix vertical screen problem
- Changes were also made to the logic in the initialize method
Copy link
Owner

@Mithil467 Mithil467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This is working fine so far.

mitype/app.py Outdated Show resolved Hide resolved
mitype/app.py Outdated Show resolved Hide resolved
@Mithil467
Copy link
Owner

I made some UI changes. Before continuing any further work ahead, I request you to update your branch with the changes on the master branch.
Checkout to the vertical_screen_fix branch and run -

git fetch origin
git rebase origin/master

@p4mela-g
Copy link
Contributor Author

p4mela-g commented Nov 6, 2020

All done! 🚀

Copy link
Owner

@Mithil467 Mithil467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great! :)

@Mithil467 Mithil467 merged commit 48fd734 into Mithil467:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical shrinking of screen beyond a limit causes app to crash
2 participants