Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options, system includes, funcs and libs #1

Open
wants to merge 53 commits into
base: main
Choose a base branch
from

Conversation

Two4
Copy link

@Two4 Two4 commented Nov 11, 2021

No description provided.

@Mizux
Copy link
Owner

Mizux commented Nov 11, 2021

Why adding gmp.h ? not sure we need it...

@Two4
Copy link
Author

Two4 commented Nov 11, 2021

Why adding gmp.h ? not sure we need it...

Windows typically doesn't have it, even if it has libgmp.dll. Compiling with GMP is much more efficient, according to the GLPK docs, so I'd like to make it a default option if possible

@Mizux
Copy link
Owner

Mizux commented Nov 11, 2021

I find this one more KISS https://github.com/dune-project/dune-common/blob/master/cmake/modules/FindGMP.cmake
especially the Modern CMake way to expose GMP::gmp and GMP::gmpxx

also there is port for gmp on vcpkg https://github.com/microsoft/vcpkg/tree/master/ports/gmp but it would need some cleanup too

src/CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
@Two4
Copy link
Author

Two4 commented Nov 13, 2021

Still a mystery error on the MSBuild CI workflow, but everything else is completing 100%. MSVC build are working fine on my machine, but we've all heard the ol' "it works on my machine" schtick before

@Two4 Two4 deleted the branch Mizux:main November 13, 2021 17:24
@Two4 Two4 closed this Nov 13, 2021
@Two4 Two4 deleted the main branch November 13, 2021 17:24
@Two4
Copy link
Author

Two4 commented Nov 13, 2021

This was unintended, I renamed the branch - didn't think it would delete it

@Two4 Two4 restored the main branch November 13, 2021 17:25
@Two4 Two4 reopened this Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants