Fixed initialisation of substitute models in ForwardMappingModel

[sigveka]

I think this fix ("elif" statement in line 188 in Strategy.py) is a temporary one.

The problem is a flaw in ModenaFireTask, run_task (line 980), where if 'point' in self will never be True for a ForwardMappingModel. Consequently, only the substitute models in for BackwardMappingModel s will be checked and instantiated.

[henrus]

Hi Sigve, Hi Christos,

merged.

@christos: Does this fix your problem?

Henrik

On 24/03/16 23:24, Sigve Karolius wrote:

I think this fix ("elif" statement in line 188 in Strategy.py) is a
temporary one.

The problem is a flaw in ModenaFireTask, |run_task| (line 980), where
|if 'point' in self| will never be |True| for a
/ForwardMappingModel/. Consequently, only the substitute models in for
_BackwardMappingModel_s will be checked and instantiated.

---

    You can view, comment on, or merge this pull request online at:

#85

    Commit Summary

• catching up with Henrik

• Fixed initialisation of substitute models in ForwardMappingModels

  File Changes
  

• M
  applications/PUfoam/MoDeNaModels/Rheology/Example_WorkflowIntegration/initModels_rh
  https://github.com/MoDeNa-EUProject/MoDeNa/pull/85/files#diff-0 (4)

• A
  applications/PUfoam/MoDeNaModels/Rheology/Example_WorkflowIntegration/src_dummy/workflowdummy
  https://github.com/MoDeNa-EUProject/MoDeNa/pull/85/files#diff-1 (0)

• M
  applications/PUfoam/MoDeNaModels/Rheology/Example_WorkflowIntegration/src_dummy/workflowdummy.f90
  https://github.com/MoDeNa-EUProject/MoDeNa/pull/85/files#diff-2
  (10)

• M applications/PUfoam/MoDeNaModels/Rheology/Rheology.py
  https://github.com/MoDeNa-EUProject/MoDeNa/pull/85/files#diff-3 (2)

• A
  applications/PUfoam/MoDeNaModels/Rheology_Arrhenius/Rheology_Arrhenius.py
  https://github.com/MoDeNa-EUProject/MoDeNa/pull/85/files#diff-4
  (110)

• M
  applications/PUfoam/MoDeNaModels/SurfaceTension/SurfaceTension.py
  https://github.com/MoDeNa-EUProject/MoDeNa/pull/85/files#diff-5 (4)

• M src/python/Strategy.py
  https://github.com/MoDeNa-EUProject/MoDeNa/pull/85/files#diff-6 (7)

• M src/python/SurrogateModel.py
  https://github.com/MoDeNa-EUProject/MoDeNa/pull/85/files#diff-7 (8)

  Patch Links:
  

• https://github.com/MoDeNa-EUProject/MoDeNa/pull/85.patch

• https://github.com/MoDeNa-EUProject/MoDeNa/pull/85.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#85

Dr. Henrik Rusche
WIKKI Ltd.
Unit 459 Southbank House Tel: +44 (0)20 3176 7190
Black Prince Road E-mail: h.rusche@wikki.co.uk

London SE1 7SJ, United Kingdom

www.wikki.co.uk