Skip to content
This repository has been archived by the owner on May 31, 2022. It is now read-only.

Accept and return an array – episode 2 #3

Merged
merged 2 commits into from
May 9, 2017
Merged

Accept and return an array – episode 2 #3

merged 2 commits into from
May 9, 2017

Conversation

mvasilkov
Copy link
Contributor

Hi again,

This is the proper pull request:

  • Make the function accept (and return) an array of lines
  • Fix a bug with '0' being replaced (see the last test case)
  • Move /\s+/ to a variable, similar to /^\s+/
  • Test names are in the first person

@coveralls
Copy link

coveralls commented May 4, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling bbf5059 on mvasilkov:patch-1 into f1d2141 on MoOx:master.

@MoOx MoOx merged commit cd9e775 into MoOx:master May 9, 2017
@MoOx
Copy link
Owner

MoOx commented May 9, 2017

Thanks!

@MoOx
Copy link
Owner

MoOx commented May 9, 2017

Released as 1.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvasilkov @coveralls @MoOx