Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace testling (this project is dead) #63

Closed
MoOx opened this issue Mar 12, 2016 · 6 comments
Closed

Replace testling (this project is dead) #63

MoOx opened this issue Mar 12, 2016 · 6 comments

Comments

@MoOx
Copy link
Owner

MoOx commented Mar 12, 2016

I have 2 HDD and cannot start testling due to a really stupid bug (I opened an issue several months/years ago)

tape-testing/testling#111

@MoOx
Copy link
Owner Author

MoOx commented Mar 12, 2016

@BehindTheMath
Copy link
Collaborator

I've been doing research on options for testing.

It seems that since pjax doesn't do any rendering, most of the goals of testing could be achieved by just using jsdom. This won't indicate any browser-specific quirks, but I think as of now, those should be ironed out, and testing is really to prevent regressions.

I've gotten all the tests to pass using jsdom, with a few small fixes to account for the differences between it and a real browser.

@MoOx what's your opinion?

@BehindTheMath
Copy link
Collaborator

One thing that will have to changed regardless, is the REST API used for testing XHR requests. The Github API refuses requests with custom headers, due to CORS.

I've tested using httpbin instead, and that seems to be working as expected.

@MoOx
Copy link
Owner Author

MoOx commented Jan 8, 2018

jsdom is ok for me!

@BehindTheMath
Copy link
Collaborator

On the subject of testing, It looks like the Travis config needs to be updated. It's running Node 0.10 and NPM 2, which are way out of date. I don't know where that's coming from, since those aren't specified in .travis.yml

@MoOx
Copy link
Owner Author

MoOx commented Jan 8, 2018

it's default travis version :/

BehindTheMath added a commit that referenced this issue Jan 8, 2018
See #63

- Switch from testling to jsdom for browser APIs
- Switch from coverify to nyc for coverage reports
- Clean up related dead code and tooling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants