Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable webpack mode #55

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Customizable webpack mode #55

merged 3 commits into from
Apr 27, 2021

Conversation

nkrusch
Copy link
Contributor

@nkrusch nkrusch commented Apr 27, 2021

Enables overriding webpack mode in project by explicitly specifying it in the project build config.

@zicsus
Copy link
Collaborator

zicsus commented Apr 27, 2021

Hey, is this per script?
I think we should make it universal.

@nkrusch
Copy link
Contributor Author

nkrusch commented Apr 27, 2021

Got it, I will change it to universal.

@zicsus
Copy link
Collaborator

zicsus commented Apr 27, 2021

NO DON'T, Ignore the comment. We have flag for universal. I'm stupid 😅

@zicsus zicsus merged commit b5d7456 into master Apr 27, 2021
@nkrusch
Copy link
Contributor Author

nkrusch commented Apr 27, 2021

Got it OK, no problem

@nkrusch nkrusch deleted the webpack-mode branch April 27, 2021 04:37
@zicsus
Copy link
Collaborator

zicsus commented Apr 27, 2021

Can you make a release for it?

@nkrusch
Copy link
Contributor Author

nkrusch commented Apr 27, 2021

I just published 1.0.3-alpha.2

@nkrusch
Copy link
Contributor Author

nkrusch commented Apr 27, 2021

I need to update docs to include this option, but in the meantime where you have the slow build, for that script add explicit option "mode":"development".

@nkrusch nkrusch linked an issue Apr 27, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Production build is really slow.
2 participants