Fix PRODUCT_MODULE_NAME calculation for external repos
#253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed to use `swift_common.derive_module_name()`. We now only set a product module name for Swift targets, since the module name for Objective-C targets comes from the modulemap, which is supplied to us from Bazel.
brentleyjones
force-pushed
the
bj/correct-module_name
branch
from
0a452c1
to
c836287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to use
swift_common.derive_module_name(). We now only set a product module name for Swift targets, since the module name for Objective-C targets comes from the modulemap, which is supplied to us from Bazel.