Extract bundles in Bazel instead of copy_outputs.sh
#2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobmattrob
approved these changes
Dec 6, 2023
This gets us most of the way to fixing Xcode Previews when not using tree artifacts. The last thing needed is adding these products to an output group for Xcode previews, otherwise unfocused frameworks aren’t extracted. Signed-off-by: Brentley Jones <github@brentleyjones.com>
Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/extract-bundles-in-bazel-instead-of-copy_outputs.sh
branch
from
a4bdfb1
to
fe7ecee
Compare
brentleyjones
deleted the
bj/extract-bundles-in-bazel-instead-of-copy_outputs.sh
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2641.
This gets us most of the way to fixing Xcode Previews when not using tree artifacts. The last thing needed is adding these products to an output group for Xcode previews, otherwise unfocused frameworks aren’t extracted.