Add bazel option to build_mode and force dbg for it
#316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
force-pushed
the
bj/bwb_dbg
branch
from
1e409af
to
cf69580
Compare
cgrindel
reviewed
Apr 18, 2022
brentleyjones
force-pushed
the
bj/bwb_dbg
branch
2 times, most recently
from
06ea233
to
1f0f77b
Compare
Right now the only difference is that in `bazel` mode the `compilation_mode` is currently forced to be `dbg`. This "restriction" will be lifted when we implement proper configuration support. For now though, we need this compilation mode to enable debugging in Build with Bazel. We now also generate another set of fixtures for Build with Bazel, a.k.a "bwb".
brentleyjones
force-pushed
the
bj/bwb_dbg
branch
from
1f0f77b
to
5299300
Compare
BalestraPatrick
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the only difference is that in
bazelmode thecompilation_modeis currently forced to bedbg. This "restriction" will be lifted when we implement proper configuration support. For now though, we need this compilation mode to enable debugging in Build with Bazel.We now also generate another set of fixtures for Build with Bazel, a.k.a "bwb".