Show error when not using tree artifacts #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
force-pushed
the
bj/archived-bundles-error
branch
from
0394738
to
9c18f1a
Compare
Base automatically changed from
bj/dont-bundle-resources-in-build-with-bazel
to
main
May 3, 2022 18:40
brentleyjones
force-pushed
the
bj/archived-bundles-error
branch
from
9c18f1a
to
a430ff3
Compare
Not using tree artifacts is a lot slower, so we want to default to using them. If a project needs to use them for some reason, they can pass `archived_bundles_allowed = True` to `xcodeproj`. We change //examples/ios_app to use tree artifacts while keeping the others as they were. This will allow us to test both paths in Build with Bazel.
brentleyjones
force-pushed
the
bj/archived-bundles-error
branch
from
a430ff3
to
d75a106
Compare
cgrindel
approved these changes
May 3, 2022
brentleyjones
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not using tree artifacts is a lot slower, so we want to default to using them. If a project needs to use them for some reason, they can pass
archived_bundles_allowed = Truetoxcodeproj.We change //examples/ios_app to use tree artifacts while keeping the others as they were. This will allow us to test both paths in Build with Bazel.