Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Bazel environment variables for launchable schemes #440

Merged
merged 35 commits into from
May 17, 2022
Merged

Provide Bazel environment variables for launchable schemes #440

merged 35 commits into from
May 17, 2022

Conversation

cgrindel
Copy link
Contributor

@cgrindel cgrindel commented May 16, 2022 •
edited
Loading

  • Provide BUILD_WORKSPACE_DIRECTORY and BUILD_WORKING_DIRECTORY for launchable schemes.

@cgrindel cgrindel self-assigned this May 16, 2022
@cgrindel cgrindel changed the title [WIP] Provide Bazel environment variables in Xcode schemes [WIP] Provide Bazel environment variables in Xcode schemes for launchable targets May 16, 2022
cgrindel
cgrindel commented May 16, 2022
View reviewed changes
tools/generator/test/CreateXCSchemesTests.swift
"testAction.customLLDBInitFile did not match for \(scheme.name)",
file: file,
line: line
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was grouped with the launch action assertions. I just moved it to be with the test action assertions.

@cgrindel cgrindel changed the title [WIP] Provide Bazel environment variables in Xcode schemes for launchable targets Provide Bazel environment variables for launchable schemes May 16, 2022
@cgrindel cgrindel marked this pull request as ready for review May 16, 2022 19:42
@cgrindel cgrindel enabled auto-merge (squash) May 16, 2022 19:42
@cgrindel
Add bazel_workspace_name to project spec and DTO
e88e7ee
@cgrindel
-m
534b6bf
@cgrindel
Undo unintended formatting
17e6155
@cgrindel
Remove unintended formatting
a603b53
@cgrindel
Move bazelWorkspaceName to follow name
9574c93
@cgrindel
Move bazel_workspace_name in project JSON
e957661
@cgrindel
Save work
3b4889e
@cgrindel
Fix the spelling of the env variables
77020d4
@cgrindel
Start refactor of env variable creation
48a653d
@cgrindel
Add more plumbing for env variable creation and selection
954cfd7
@cgrindel
Set up placeholders for tests
54bc269
@cgrindel
Save progress on env vars tests
b3cda38
@cgrindel
Rename test file and finish impl
5342497
@cgrindel
Doc and cleanup
72adfc7
@cgrindel
Add build mode check for env vars
156858d
@cgrindel
Plumb project into createXCSchemes
3e514dc
@cgrindel
Update format
75f8f5e
@cgrindel
Move bazelWorkspaceName location
b78c49b
@cgrindel
Add PBXProductType bazelLaunchEnvironmentVariables tests
ee3f251
@cgrindel
Add tests for createBazelTestEnvironmentVariables
c9bc9a4
@cgrindel cgrindel force-pushed the cg/provide_bazel_env_vars_in_schemes branch from a195834 to 6425299 Compare May 17, 2022 17:05
@cgrindel cgrindel merged commit 1ab5816 into main May 17, 2022
@cgrindel cgrindel deleted the cg/provide_bazel_env_vars_in_schemes branch May 17, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentleyjones brentleyjones brentleyjones approved these changes

Assignees

@cgrindel cgrindel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgrindel @brentleyjones