Apply filtering logic to generated extra_files, and xccurrentversions as well
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the `generated_inputs` output group from having unnecessary files in it.
cgrindel
approved these changes
May 18, 2022
| for attr, info in transitive_infos | ||
| if (not attrs_info or | ||
| info.target_type in | ||
| attrs_info.xcode_targets.get(attr, [None])) |
There was a problem hiding this comment.
Curious. Why return a default of [None] vs []?
There was a problem hiding this comment.
Because it does an in check, and info.target_type can be None, and that needs to be True.
This filtering is very redundant, and error prone (as shown by this and previous changes applying missing filtering). This will get addressed with the forthcoming input file collection refactor.
brentleyjones
changed the title
generated extra_files, and xccurrentversions as well
brentleyjones
deleted the
bj/filter-generated-files-the-same-as-other-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the
generated_inputsoutput group from having unnecessary files in it. This filtering is very redundant, and error prone (as shown by this and previous changes applying missing filtering). This will get addressed with the forthcoming input file collection refactor.