Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat more file extensions as headers #468

Merged
merged 3 commits into from
May 24, 2022

Conversation

jpsim
Copy link
Contributor

@jpsim jpsim commented May 24, 2022

XcodeProj exposes a list of file extensions for headers, which we can use to handle a broader set of file types as headers.

Specifically: h, hh, hpp, ipp, tpp, hxx, def, inl, inc

XcodeProj exposes a list of file extensions for headers, which we can
use to handle a broader set of file types as headers.

Specifically: h, hh, hpp, ipp, tpp, hxx, def, inl, inc
@jpsim jpsim marked this pull request as ready for review May 24, 2022 17:10
case "hpp": return true
default: return false
if let ext = `extension` {
return Xcode.headersExtensions.contains(".\(ext)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

tools/generator/src/Path+Extensions.swift Show resolved Hide resolved
@brentleyjones brentleyjones enabled auto-merge (squash) May 24, 2022 18:02
@brentleyjones brentleyjones merged commit abc4d80 into main May 24, 2022
@brentleyjones brentleyjones deleted the treat-more-file-extensions-as-headers branch May 24, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants