Use the correct version of swiftc for BwB SwiftUI Previews #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same logic that we use in the ld stub, for the same reason: the `PATH` and `DEVELOPER_DIR` isn't set correctly for us, so we have to infer what `DEVELOPER_DIR` is. We also force the use of the default toolchain, which means this currently doesn't work correctly with custom toolchains.
BalestraPatrick
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
@brentleyjones What's exactly the reason why it's not set correctly in this mode?
brentleyjones
deleted the
bj/use-the-correct-version-of-swiftc-for-bwb-swiftui-previews
branch
|
When we don't set the stub, Xcode uses the absolute path to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same logic that we use in the
ldstub, for the same reason: thePATHandDEVELOPER_DIRisn't set correctly for us, so we have to infer whatDEVELOPER_DIRis. We also force the use of the default toolchain, which means this currently doesn't work correctly with custom toolchains.