Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose NSExtensionPointIdentifier to generator #687

Merged

Conversation

brentleyjones
Copy link
Contributor

This will be used by the scheme generation code to properly create schemes for WidgetKit extensions.

@brentleyjones brentleyjones enabled auto-merge (squash) July 8, 2022 15:26
@brentleyjones brentleyjones force-pushed the bj/expose-nsextensionpointidentifier-to-generator branch from 2167deb to 117ed4d Compare July 8, 2022 15:28
Copy link
Contributor

@cgrindel cgrindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to add some tool-specific tests at some point. It might help other folks who may need to make changes to not break anything. 🙂

@brentleyjones
Copy link
Contributor Author

What do you mean?

In regards to this PR, it's just split from a larger one that uses it, to make them easier to review. That one will be submitted soon.

@brentleyjones
Copy link
Contributor Author

brentleyjones commented Jul 8, 2022

Ahh. I don't have tests as the fixtures would catch a break. I agree we could have more tests, but since I have some coverage, I'm willing to go fast here instead.

@brentleyjones brentleyjones force-pushed the bj/expose-nsextensionpointidentifier-to-generator branch from 117ed4d to b361b20 Compare July 8, 2022 17:31
This will be used by the scheme generation code to properly create schemes for WidgetKit extensions.
@brentleyjones brentleyjones force-pushed the bj/expose-nsextensionpointidentifier-to-generator branch from b361b20 to 5f5253a Compare July 8, 2022 17:42
@brentleyjones brentleyjones merged commit b7fc4b4 into main Jul 8, 2022
@brentleyjones brentleyjones deleted the bj/expose-nsextensionpointidentifier-to-generator branch July 8, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants