Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-8414] Improve Kafka documentation #136

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Aug 30, 2023

Change Summary

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Aug 30, 2023
@dolfinus dolfinus temporarily deployed to test-pypi August 30, 2023 10:43 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #136 (9213fb4) into develop (58f28b2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #136   +/-   ##
========================================
  Coverage    94.29%   94.29%           
========================================
  Files          207      207           
  Lines         7697     7697           
  Branches      1451     1451           
========================================
  Hits          7258     7258           
  Misses         320      320           
  Partials       119      119           
Files Changed Coverage Δ
onetl/connection/db_connection/kafka/connection.py 98.97% <ø> (ø)
...nnection/db_connection/kafka/kafka_ssl_protocol.py 100.00% <ø> (ø)
onetl/connection/db_connection/kafka/options.py 100.00% <ø> (ø)

@dolfinus dolfinus marked this pull request as ready for review August 30, 2023 11:02
@dolfinus dolfinus temporarily deployed to test-pypi August 30, 2023 11:24 — with GitHub Actions Inactive
@dolfinus dolfinus merged commit fde6b30 into develop Sep 1, 2023
31 checks passed
@dolfinus dolfinus deleted the feature/DOP-8414 branch September 1, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants