Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-9007] Add ivysettings.xml examples to documentation #151

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Sep 19, 2023

Change Summary

  • Added a page describing different ways of passing packages to Spark session. This page previously was a part of Greenplum documentation.
  • Add more examples and descriptions of adding Java packages to Spark session
  • Moved Python packages installation instruction from documentation root to subdir "How to install". Java packages instruction is moved to the same subdir.

See https://onetl--151.org.readthedocs.build/en/151/install/index.html

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus temporarily deployed to test-pypi September 19, 2023 15:54 — with GitHub Actions Inactive
@dolfinus dolfinus self-assigned this Sep 19, 2023
@dolfinus dolfinus temporarily deployed to test-pypi September 19, 2023 15:56 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi September 19, 2023 15:59 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi September 19, 2023 16:07 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi September 19, 2023 16:07 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi September 19, 2023 16:08 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #151 (2c97943) into develop (252ce9a) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #151      +/-   ##
===========================================
- Coverage    94.32%   94.30%   -0.03%     
===========================================
  Files          208      208              
  Lines         7775     7775              
  Branches      1465     1465              
===========================================
- Hits          7334     7332       -2     
- Misses         321      322       +1     
- Partials       120      121       +1     

see 1 file with indirect coverage changes

@dolfinus dolfinus temporarily deployed to test-pypi September 20, 2023 09:35 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi September 20, 2023 09:43 — with GitHub Actions Inactive
@dolfinus dolfinus temporarily deployed to test-pypi September 20, 2023 10:14 — with GitHub Actions Inactive
@dolfinus dolfinus marked this pull request as ready for review September 20, 2023 10:51
@dolfinus dolfinus temporarily deployed to test-pypi September 20, 2023 10:51 — with GitHub Actions Inactive
@dolfinus dolfinus merged commit 6313b12 into develop Sep 21, 2023
31 checks passed
@dolfinus dolfinus deleted the improvement/DOP-9007 branch September 21, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants