Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-13850] - upgrade Oracle packages #252

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Apr 16, 2024

Change Summary

  • Oracle connection now uses Oracle JDBC driver 23.3.0.0.23.09, upgraded from 23.2.0.0, and supports passing custom versions: Oracle.get_packages(java_version=..., package_version=...).
  • Update following documentation and tests.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus
Copy link
Member

Документация похоже начала падать из-за того, что подтянулась какая-то новая версия зависимости. Я гляну

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.40%. Comparing base (bd2f824) to head (29dc453).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #252   +/-   ##
========================================
  Coverage    94.40%   94.40%           
========================================
  Files          204      204           
  Lines         7897     7898    +1     
  Branches      1403     1402    -1     
========================================
+ Hits          7455     7456    +1     
  Misses         317      317           
  Partials       125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxim-lixakov maxim-lixakov merged commit 5819e21 into develop Apr 17, 2024
33 of 34 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-13850 branch April 17, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants