Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-15749] - separate ReadOptions into ReadOptions and SQLOptions #272

Merged
merged 4 commits into from
May 16, 2024

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented May 15, 2024

Change Summary

  • ReadOptions and SQLOptions have been separated for JDBC connections. SQLOptions is now required for .sql method calls
  • Add following tests and documentation

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 97.36842% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.46%. Comparing base (09973cf) to head (265fa6d).

Files Patch % Lines
...onnection/db_connection/jdbc_connection/options.py 96.15% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #272      +/-   ##
===========================================
- Coverage    94.48%   94.46%   -0.02%     
===========================================
  Files          204      204              
  Lines         8012     8047      +35     
  Branches      1405     1409       +4     
===========================================
+ Hits          7570     7602      +32     
- Misses         319      320       +1     
- Partials       123      125       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus
Copy link
Member

В unit тестах есть test_jdbc_read_options_default. Нужно сделать такой же для SQLOptions.

Co-authored-by: Maxim Martynov <msmarty5@mts.ru>
@maxim-lixakov maxim-lixakov merged commit 3cd5dfc into develop May 16, 2024
37 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-15749 branch May 16, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants