-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-15749] - separate ReadOptions into ReadOptions and SQLOptions #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
reviewed
May 15, 2024
dolfinus
reviewed
May 15, 2024
dolfinus
reviewed
May 15, 2024
dolfinus
reviewed
May 15, 2024
maxim-lixakov
force-pushed
the
feature/DOP-15749
branch
from
May 15, 2024 15:11
3696d19
to
e9bddb5
Compare
dolfinus
reviewed
May 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #272 +/- ##
===========================================
- Coverage 94.48% 94.46% -0.02%
===========================================
Files 204 204
Lines 8012 8047 +35
Branches 1405 1409 +4
===========================================
+ Hits 7570 7602 +32
- Misses 319 320 +1
- Partials 123 125 +2 ☔ View full report in Codecov by Sentry. |
dolfinus
reviewed
May 16, 2024
maxim-lixakov
force-pushed
the
feature/DOP-15749
branch
from
May 16, 2024 09:05
94e90c7
to
2817967
Compare
dolfinus
reviewed
May 16, 2024
maxim-lixakov
force-pushed
the
feature/DOP-15749
branch
from
May 16, 2024 09:42
2817967
to
d3febab
Compare
dolfinus
reviewed
May 16, 2024
maxim-lixakov
force-pushed
the
feature/DOP-15749
branch
from
May 16, 2024 09:51
26b54bb
to
129c034
Compare
dolfinus
reviewed
May 16, 2024
В unit тестах есть |
Co-authored-by: Maxim Martynov <msmarty5@mts.ru>
maxim-lixakov
force-pushed
the
feature/DOP-15749
branch
from
May 16, 2024 11:44
129c034
to
265fa6d
Compare
dolfinus
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
ReadOptions
andSQLOptions
have been separated for JDBC connections.SQLOptions
is now required for.sql
method callsRelated issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)