Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-15749] - add ExecuteOptions, FetchOptions #274

Merged
merged 1 commit into from
May 20, 2024

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented May 17, 2024

Change Summary

  • Divide general JDBCOptions into FetchOptions for fetching data and ExecuteOptions for executing statements.
  • Add following tests and documentation.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.48%. Comparing base (24660e5) to head (456b085).
Report is 72 commits behind head on develop.

Files Patch % Lines
...l/connection/db_connection/greenplum/connection.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #274      +/-   ##
===========================================
+ Coverage    94.46%   94.48%   +0.01%     
===========================================
  Files          204      204              
  Lines         8047     8068      +21     
  Branches      1409     1410       +1     
===========================================
+ Hits          7602     7623      +21     
  Misses         320      320              
  Partials       125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxim-lixakov maxim-lixakov enabled auto-merge (squash) May 20, 2024 14:28
@maxim-lixakov maxim-lixakov merged commit bacb483 into develop May 20, 2024
37 of 38 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-15762 branch May 20, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants