-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-15749] - add ExecuteOptions, FetchOptions #274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim-lixakov
force-pushed
the
feature/DOP-15762
branch
from
May 17, 2024 11:55
9b85977
to
1aeee47
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #274 +/- ##
===========================================
+ Coverage 94.46% 94.48% +0.01%
===========================================
Files 204 204
Lines 8047 8068 +21
Branches 1409 1410 +1
===========================================
+ Hits 7602 7623 +21
Misses 320 320
Partials 125 125 ☔ View full report in Codecov by Sentry. |
maxim-lixakov
force-pushed
the
feature/DOP-15762
branch
from
May 17, 2024 12:05
1aeee47
to
41875c9
Compare
dolfinus
reviewed
May 17, 2024
dolfinus
reviewed
May 17, 2024
dolfinus
reviewed
May 17, 2024
tests/tests_integration/tests_db_connection_integration/test_greenplum_integration.py
Outdated
Show resolved
Hide resolved
dolfinus
reviewed
May 17, 2024
maxim-lixakov
force-pushed
the
feature/DOP-15762
branch
from
May 17, 2024 13:45
41875c9
to
5c67306
Compare
maxim-lixakov
force-pushed
the
feature/DOP-15762
branch
from
May 20, 2024 13:14
5c67306
to
8b14915
Compare
dolfinus
reviewed
May 20, 2024
dolfinus
reviewed
May 20, 2024
tests/tests_integration/tests_db_connection_integration/test_postgres_integration.py
Outdated
Show resolved
Hide resolved
maxim-lixakov
force-pushed
the
feature/DOP-15762
branch
from
May 20, 2024 13:23
8b14915
to
db2598e
Compare
maxim-lixakov
force-pushed
the
feature/DOP-15762
branch
from
May 20, 2024 13:48
db2598e
to
29d8e3d
Compare
dolfinus
reviewed
May 20, 2024
tests/tests_integration/tests_db_connection_integration/test_postgres_integration.py
Outdated
Show resolved
Hide resolved
maxim-lixakov
force-pushed
the
feature/DOP-15762
branch
from
May 20, 2024 14:16
29d8e3d
to
456b085
Compare
dolfinus
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
JDBCOptions
intoFetchOptions
for fetching data andExecuteOptions
for executing statements.Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)