Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-13900] Add note about connecting to Clickhouse cluster #280

Merged
merged 1 commit into from
May 23, 2024

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented May 23, 2024

Change Summary

New Clickhouse driver can autodiscover cluster nodes, and choose any of nodes while establishing new connection. Add note about enabling this feature to Prerequisites page.

Also add few small fixes to Types page.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.79%. Comparing base (1f73652) to head (ffe408d).
Report is 71 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #280   +/-   ##
========================================
  Coverage    94.79%   94.79%           
========================================
  Files          210      210           
  Lines         8187     8187           
  Branches      1410     1410           
========================================
  Hits          7761     7761           
  Misses         304      304           
  Partials       122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus merged commit 2a7e013 into develop May 23, 2024
35 checks passed
@dolfinus dolfinus deleted the feature/DOP-13900 branch May 23, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants