Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Change Java distribution adopt->temurin #1118

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

barbeau
Copy link
Member

@barbeau barbeau commented Mar 25, 2022

Summary:

https://github.com/actions/setup-java#supported-distributions says:

NOTE: Adopt OpenJDK got moved to Eclipse Temurin and won't be updated anymore. It is highly recommended to migrate workflows from adopt to temurin to keep receiving software and security updates. See more details in the Good-bye AdoptOpenJDK post.)

This PR changes GitHub Actions to use temurin instead of adopt as highly recommended above.

It also updates acceptance_test to use actions/setup-java@v2 instead of actions/setup-java@v1 to be consistent with the other GitHub Actions.

Expected behavior:

Use temurin Java distribution on CI instead of adopt, use actions/setup-java@v2 consistently.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

https://github.com/actions/setup-java#supported-distributions says:

>NOTE: Adopt OpenJDK got moved to Eclipse Temurin and won't be updated anymore. It is highly recommended to migrate workflows from adopt to temurin to keep receiving software and security updates. See more details in the [Good-bye AdoptOpenJDK post](https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/).)

This PR changes GitHub Actions to use temurin instead of adopt as highly recommended above.

It also updates acceptance_test to use actions/setup-java@v2 instead of actions/setup-java@v1 to be consistent with the other GitHub Actions.
@github-actions
Copy link
Contributor

Thank you for this contribution! 🍰✨🦄

Information about source corruption

0 out of 1248 sources are corrupted.

Acceptance test details

The changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase.
Download the full acceptance test report for commit 269cfc3 here (report will disappear after 90 days).

Copy link
Contributor

@isabelle-dr isabelle-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Sean!

@isabelle-dr isabelle-dr merged commit 62e8901 into master Apr 12, 2022
@isabelle-dr isabelle-dr deleted the sean/ci-adopt-to-temurin branch April 12, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants