-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add code for computing service coverage windows and trip counts #1351
Conversation
…s and service windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @bdferris-v2 Thank you for this - I will incorporate this into my PR. @isabelle-dr What is the appropriate way of merging - merge into master and then merge master into PR #1289, or merge this into #1289 and close this one?
✅ Rule acceptance tests passed. |
@davidgamez @isabelle-dr Could someone take a look and merge this so that I can use it in #1289? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
✅ Rule acceptance tests passed. |
…MobilityData#1351) Add TripCalendarUtil, which provides methods for computing trip counts and service windows.
Adds
TripCalendarUtil
, which provides methods for computing service coverage windows based on daily trip counts.Will hopefully be useful for #886 and PR #1289.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything