Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed route name and agency information components #1659

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Jan 25, 2024

Summary:
Part 2 of #1640
Remove route name and agency information from GTFS components

Expected behavior:
image
image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@qcdyx qcdyx requested review from emmambd and jcpitre January 25, 2024 14:30
Copy link
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Flagging that route-based fares component needs to be added still - I assume in a separate PR.

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qcdyx qcdyx changed the title Feat: removed route name and agency information components feat: removed route name and agency information components Jan 25, 2024
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1460 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1460 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1460 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1460 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
20 out of 1480 sources (~1 %) are corrupted.
Corrupted sources:
au-queensland-innisfail-gtfs-1163
au-queensland-translink-sunbus-cairns-gtfs-674
au-queensland-whitsunday-transit-gtfs-676
au-victoria-port-phillip-ferries-gtfs-649
be-unknown-societe-regionale-wallonne-du-transport-gtfs-1212
ca-british-columbia-bc-transit-cranbrook-gtfs-706
ca-british-columbia-bc-transit-squamish-gtfs-701
ca-british-columbia-bc-transit-sunshine-coast-transit-system-gtfs-700
ca-british-columbia-bc-transit-whistler-transit-system-gtfs-702
ca-british-columbia-south-okanagan-similkameen-gtfs-762
ca-ontario-ottawa-carleton-regional-transit-commission-oc-transpo-gtfs-738
ca-ontario-toronto-transit-commission-gtfs-732
ca-quebec-exo-chambly-richelieu-carignan-gtfs-750
ca-quebec-societe-de-transport-de-sherbrooke-gtfs-756
ca-quebec-terrebonne-mascouche-gtfs-754
cy-unknown-intercity-buses-gtfs-1917
fr-hauts-de-france-communaute-urbaine-de-dunkerque-reseau-dk-bus-gtfs-664
it-puglia-miccolis-spa-gtfs-912
us-california-blue-gold-fleet-gtfs-1178
us-colorado-epic-mountain-express-gtfs-1213
Commit: fd2f300
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@qcdyx qcdyx merged commit a734495 into master Jan 25, 2024
333 checks passed
@qcdyx qcdyx deleted the 1640-remove-components-add-GtfsNetworkSchema branch January 25, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants