feat: Treat empty files as parsed unsuccessfully #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmptyFileNotice is already an ERROR. We have verified on 3K feeds at Google that none provides empty CSV file (i.e. a file that contains no rows and no headers). We do not see a use case for empty files in GTFS. Since an empty file is an error, we do not invoke single-file validators for it. Cross-file validations will not be invoked if any file is completely empty. In future we may merge EMPTY_FILE, INVALID_HEADERS and UNPARSABLE_ROWS into a single constant.
|
Thanks, Darcy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EmptyFileNotice is already an ERROR.
We have verified on 3K feeds at Google that none provides empty CSV file
(i.e. a file that contains no rows and no headers). We do not see a use
case for empty files in GTFS.
Since an empty file is an error, we do not invoke single-file validators
for it. Cross-file validations will not be invoked if any file is
completely empty.
In future we may merge EMPTY_FILE, INVALID_HEADERS and UNPARSABLE_ROWS
into a single constant.