Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upload integration tests results if tests fail #326

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

jcpitre
Copy link
Contributor

@jcpitre jcpitre commented Mar 5, 2024

Summary:

Modified GH actions to upload integration tests logs in case of a failure of the tests. That should help to know what went wrong.
This was asked for in #319

Also corrected some typos here and there.

Expected behavior:

If the integration tests fail during the api deployment the integration tests results should still be uploaded to Github.

Testing tips:

To test this properly we would need to have the API integration tests fail.
I tested by introducing an artificial error in integration-tests.yml (added an exit 1). But that requires changes to the codebase then push. This can be done in a throwaway branch.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@jcpitre jcpitre marked this pull request as ready for review March 5, 2024 14:28
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcpitre jcpitre merged commit ab2fa45 into main Mar 5, 2024
7 checks passed
@jcpitre jcpitre deleted the upload-integration-tests-results branch March 5, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants