fix: Upload integration tests results if tests fail #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Modified GH actions to upload integration tests logs in case of a failure of the tests. That should help to know what went wrong.
This was asked for in #319
Also corrected some typos here and there.
Expected behavior:
If the integration tests fail during the api deployment the integration tests results should still be uploaded to Github.
Testing tips:
To test this properly we would need to have the API integration tests fail.
I tested by introducing an artificial error in integration-tests.yml (added an exit 1). But that requires changes to the codebase then push. This can be done in a throwaway branch.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.sh
to make sure you didn't break anything