Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added unique_error_count, unique_warning_count, unique_info_count. #453

Merged
merged 1 commit into from
May 30, 2024

Conversation

jcpitre
Copy link
Contributor

@jcpitre jcpitre commented May 30, 2024

Summary:
closes #439
Added unique_error_count, unique_warning_count, unique_info_count.

Expected behavior:

The validation report sections of dataset API response should now have unique_error_count, unique_warning_count, unique_info_count.

Testing tips:
api/tests/test_data/test_datasets.json was modified to add more error notices.
You can test using this file (See https://github.com/MobilityData/mobility-feed-api?tab=readme-ov-file#installation--usage). You can modify this file to test different scenarios.

Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@jcpitre jcpitre linked an issue May 30, 2024 that may be closed by this pull request
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcpitre jcpitre merged commit f35b6a6 into main May 30, 2024
2 checks passed
@jcpitre jcpitre deleted the 439-add-total--of-unique-notices-grouped-by-severity branch May 30, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add total # of unique notices grouped by severity
2 participants