fix: feature flag 'feeds' page #492
Conversation
|
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-492-k5otr9pu.web.app |
| ); | ||
| expect(feedsNavigation).toBeUndefined(); | ||
| }); | ||
| }); |
| export enum NavigationItemVariant { | ||
| Text = 'text', | ||
| Outlined = 'outlined', | ||
| Contained = 'contained', | ||
| } |
There was a problem hiding this comment.
[suggestion] Since we only use Text -- we can get rid of this enum completely and the variant variable is NavigationItem instances.
There was a problem hiding this comment.
Would you be able to clarify? Do you mean removing the variant variable all together? To change in Header.tsx variant={item.variant} to variant={'text'}? Although right now we only use Text keep the flexibility in the future would be good?
There was a problem hiding this comment.
Yes that's my suggestion following the YAGNI principle
Always implement things when you actually need them, never when you just foresee that you need them.
This is just a suggestion. Feel free to disregard if you're in disagreement 🙂
There was a problem hiding this comment.
I'm convinced
closes #477
Summary:
Adds feature flag to 'feeds' page to hide it in PROD until it's ready
Expected behavior:
If the feature flag is disabled, 'feeds' should not appear in the nav bar, nor should it exist as a route.
Testing tips:
Go into firebase and modify the feature flag values
Go into
web-app/src/app/constants/Navigation.tsand manually modify the feature flag valuesPlease make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything