Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cypress intercepts for feed api calls #593

Merged

Conversation

davidgamez
Copy link
Member

@davidgamez davidgamez commented Jul 22, 2024

Summary:
Add cypress intercepts for feed API calls.
I tried to use the cy. fixtures command from Cypress, but its asynchronous nature makes the code less readable. This is why I used a regular JSON import for the fixtures.

Testing tips:

Provide tips, procedures and sample files on how to test the feature.
Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-593-h9vhy9b4.web.app

@davidgamez davidgamez changed the base branch from main to feat/512-513_feeds-cypress-test July 23, 2024 17:04
@davidgamez davidgamez marked this pull request as ready for review July 23, 2024 17:05
@davidgamez davidgamez changed the title Feat/512 513 feeds cypress test copy chore: add cypress intercepts for feed api calls Jul 23, 2024
Copy link
Contributor

@indraneel indraneel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@indraneel indraneel merged commit b38da04 into feat/512-513_feeds-cypress-test Jul 23, 2024
4 checks passed
@indraneel indraneel deleted the feat/512-513_feeds-cypress-test_copy branch July 23, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants