Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update api deployment with db models #81

Merged
merged 6 commits into from
Aug 15, 2023

Conversation

davidgamez
Copy link
Member

Summary:

Add DB models generation to the API deployment job

Expected behavior:

GCP cloud run API contains the DB models.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Comment on lines -5 to -9
# Uncomment the following trigger to test on dev
# push:
# branches: [ main, * ] # remove branch before merge
# paths-ignore:
# - '**.md'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this section as the job can be triggered manually.

Comment on lines -65 to +77
- name: Setup Maven Action
uses: s4u/setup-maven-action@v1.8.0
- name: Set up JDK ${{ env.java_version }}
uses: actions/setup-java@v3
with:
java-version: ${{ env.java_version }}
distribution: 'temurin'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing setup action in favor of a more stable implementation.

@davidgamez davidgamez marked this pull request as ready for review August 15, 2023 18:14
@davidgamez davidgamez requested a review from cka-y August 15, 2023 18:25
Copy link
Contributor

@cka-y cka-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@davidgamez davidgamez merged commit 0c8dbf5 into main Aug 15, 2023
1 check passed
@davidgamez davidgamez deleted the chore/update-api-deployment branch August 15, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants