-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update api deployment with db models #81
Conversation
# Uncomment the following trigger to test on dev | ||
# push: | ||
# branches: [ main, * ] # remove branch before merge | ||
# paths-ignore: | ||
# - '**.md' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this section as the job can be triggered manually.
- name: Setup Maven Action | ||
uses: s4u/setup-maven-action@v1.8.0 | ||
- name: Set up JDK ${{ env.java_version }} | ||
uses: actions/setup-java@v3 | ||
with: | ||
java-version: ${{ env.java_version }} | ||
distribution: 'temurin' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing setup action in favor of a more stable implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Summary:
Add DB models generation to the API deployment job
Expected behavior:
GCP cloud run API contains the DB models.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.sh
to make sure you didn't break anything