feat: GTFS related endpoints

[jujiang526]

Summary:
Linked Issue

Implemented the following endpoints without supporting filtering or sorting

Get GTFS feeds
Get GTFS RT feeds
Get GTFS feed by ID
Get GTFS RT feed by ID
Get GTFS feed datasets for a given feed ID
Get GTFS datasets by dataset ID

Expected behavior:

Tested all those end points. The performance is good. Added a few unit tests regarding bounding filtering and database join query.

Please make sure these boxes are checked before submitting your pull request - thanks!

• Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
• Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
• Linked all relevant issues
• Include screenshot(s) showing how this pull request works and fixes the issue(s)

[welcome]

Thanks for opening this pull request! You're awesome. We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of titles with semantic prefixes:

• fix: Bug with ssl network connections + Java module permissions.
• feat: Initial support for multiple @PrimaryKey annotations.
• docs: update RELEASE.md with new process
  To get this PR to the finish line, please do the following:
• Include tests when adding/changing behavior
• Include screenshots

[aronza]

Hi @jujiang526 ,

Thank you for all this! I've refactored it further to reduce code duplication.

Also I saw that you were mapping database feed or dataset IDs directly to API IDs. I believe @jcpitre clarified in an earlier meeting that they want us to use stable_id when accepting or returning IDs in API. I've made the changes in the code and verified in my local Postman it works as expected.

Though the tests you've added were using these database IDs that are auto-generated in https://github.com/MobilityData/mobility-feed-api/blob/02f2b6f0b2a4dddac51f7e02de220c965e9004f4/api/src/scripts/populate_db.py#L123C1-L123C1 in our locals, so these tests won't pass anywhere else. Do you know which dataset stable ID did you use for these values?

[aronza]

Found more missing functionality in this PR. The fixes are in https://github.com/MobilityData/mobility-feed-api/tree/arda/add-api-filter with the filtering functionality

[indraneel]

🚨 Do not merge this PR into main, until #94 is reviewed/merged into this branch

[aronza]

🚨 Do not merge this PR into main, until #94 is reviewed/merged into this branch

merged and resolved the conflicts from main

[jcpitre]

Added #96 to track filtering on dates for feeds.

[jujiang526]

@aronza - Can you please try to run the unit test in your environment? I believe I have fixed it. I also fixed a small issue with returning duplicated records from the joined table.

[aronza]

@aronza - Can you please try to run the unit test in your environment? I believe I have fixed it. I also fixed a small issue with returning duplicated records from the joined table.

They pass on my local too @jujiang526 . Though our changes to database class broke @goorui 's unit tests, so I refactored these tests to work with the latest changes

[jcpitre]

Is this thread safe?
If not, maybe it's irrelevant to our case. If so, can you add a comment explaining why it's not relevant?

[aronza]

@jujiang526 , I believe you've added this. Any thoughts?

[welcome]

🥳 Congrats on getting your first pull request merged!